Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommendations for VS Code and Atom #472

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

PEZ
Copy link
Contributor

@PEZ PEZ commented Jul 29, 2020

I've updated the recommended plugins/extensions for Atom, to Chlorine, and for VS Code, to Calva. In the latter case I am quite biased, but as this question suggests, clojureVSCode does not fully qualify the expectations for an editor integration as they are expressed on this page. Calva does, however.

  • Have you read the guidelines for contributing?
  • Have you signed the Clojure Contributor Agreement?
  • Have you verified your asciidoc markup is correct?

I've updated the recommended plugins/extensions for Atom, to Chlorine, and for VS Code, to Calva. In the latter case I am quite biased, but as [this question](avli/clojureVSCode#113) suggests, `clojureVSCode` does not fully qualify the expectations for an editor integration as they are expressed on this page. Calva does, however.
@puredanger
Copy link
Member

Would love to merge this, but I don't see your Clojure Contributor Agreement on file. Can you advise or complete it? https://secure.na1.echosign.com/public/hostedForm?formid=95YMDL576B336E

@PEZ
Copy link
Contributor Author

PEZ commented Jul 29, 2020

Hmmm, I signed it. Will try again then.

@PEZ
Copy link
Contributor Author

PEZ commented Jul 29, 2020

For some reason I don't get to fill in my name, just Company. So I filled in my name there. Could that be the issue?

@PEZ
Copy link
Contributor Author

PEZ commented Jul 29, 2020

Ah, so there were things hiding under the cookie banner. Now it should be signed fully.

@puredanger puredanger merged commit 13debed into clojure:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants